opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

OTLP JSON exporter cannot be released

Open dyladan opened this issue 3 years ago • 8 comments

Currently, we are preparing to release the OTLP trace exporters as 1.x 🎉

Unfortunately, because OTLP JSON is experimental we cannot release the JSON exporter as 1.x and it must be held back to 0.x 😢

This is important because the transformations from our internal representation to the OTLP JSON representation are in the HTTP JSON exporter, and are depended on by the proto and gRPC exporters. If we hold back the JSON exporter but not the gRPC and proto exporters, we will end up in a situation where 1.x exporters depend on the 0.x exporter.

Possible resolutions:

  1. Hold back all OTLP exporters
  2. Prioritize #2691 or #2746 and hold all exporters release until it is complete
  3. Hold back HTTP/JSON exporter and accept that the proto/gRPC exporters will depend on an experimental package until #2691 or #2746 is implemented

dyladan avatar Feb 24 '22 19:02 dyladan

I would be in favor of 2), i think it's better to have a "real" GA to avoid misunderstanding for users. (Btw i also think https://github.com/open-telemetry/opentelemetry-js/pull/2746 is preferable over https://github.com/open-telemetry/opentelemetry-js/pull/2691 for now, we could still switch back to codegen once it covers every issue)

vmarchaud avatar Feb 25 '22 08:02 vmarchaud

One more advantage of #2746 is that it separates the transformation code from the code that encodes protobuf which makes it easier to pack a small bundle for the web. I'll try to get that PR updated today.

dyladan avatar Feb 25 '22 13:02 dyladan

2 or 3 would be preferred for us.

icco avatar Mar 09 '22 02:03 icco

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar May 09 '22 06:05 github-actions[bot]

Not stale and still experimental

dyladan avatar May 10 '22 20:05 dyladan

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Jul 11 '22 06:07 github-actions[bot]

This issue was closed because it has been stale for 14 days with no activity.

github-actions[bot] avatar Aug 01 '22 06:08 github-actions[bot]

We can release the non-json exporters now that protobuf exporters are codegen and grpc exporters have their own base right?

dyladan avatar Aug 02 '22 18:08 dyladan