opentelemetry-js-contrib icon indicating copy to clipboard operation
opentelemetry-js-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

cleanup `@opentelemetry/resource-detector-docker` references

Open trentm opened this issue 9 months ago • 1 comments

The @opentelemetry/resource-detector-docker package was replaced by @opentelemetry/resource-detector-container in https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1181 in 2022. That isn't clear from https://www.npmjs.com/package/@opentelemetry/resource-detector-docker

  • The package should be marked deprecated in npm.
  • https://github.com/open-telemetry/opentelemetry.io/blob/b6ddba1118d07bc3c8d1d07b293f227686d0290e/content/en/docs/languages/js/resources.md#container-resource-detection currently uses @opentelemetry/resource-detector-docker. It should be updated to use the newer package.

trentm avatar Feb 20 '25 00:02 trentm

I deprecated it in npm: https://www.npmjs.com/package/@opentelemetry/resource-detector-docker. Only the docs update is left now.

pichlermarc avatar Feb 21 '25 09:02 pichlermarc

I can take this one to update the docs.

@pichlermarc can you assign this to me, please?

vitorvasc avatar Apr 15 '25 11:04 vitorvasc

done @vitorvasc :D

maryliag avatar Apr 15 '25 12:04 maryliag

@vitorvasc Did you get a chance to look at this? Let me know if you'd still like to stay assigned, otherwise we can open it up for someone else to grab.

trentm avatar Oct 16 '25 00:10 trentm

Hi folks!

Sorry for losing track of this issue after it was assigned. I've just opened the PR with the updates, here it is: https://github.com/open-telemetry/opentelemetry.io/pull/8114

vitorvasc avatar Oct 16 '25 10:10 vitorvasc

Thanks!

trentm avatar Oct 16 '25 16:10 trentm