opentelemetry-js-contrib
opentelemetry-js-contrib copied to clipboard
feat: add sequelize instrumentation
Add sequelize instrumentation originally created by Aspecto.
Contains minor changes compared to the original: updated to latest semantic conventions and instrumentation package, moved the tests to assert.
Codecov Report
:x: Patch coverage is 94.28571% with 6 lines in your changes missing coverage. Please review.
:warning: Please upload report for BASE (main@215c2b5). Learn more about missing BASE report.
:warning: Report is 21 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...s/instrumentation-sequelize/src/instrumentation.ts | 94.89% | 5 Missing :warning: |
| packages/instrumentation-sequelize/src/utils.ts | 85.71% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2396 +/- ##
=======================================
Coverage ? 89.11%
=======================================
Files ? 190
Lines ? 9326
Branches ? 1923
=======================================
Hits ? 8311
Misses ? 1015
Partials ? 0
| Files with missing lines | Coverage Δ | |
|---|---|---|
| packages/instrumentation-sequelize/src/utils.ts | 85.71% <85.71%> (ø) |
|
| ...s/instrumentation-sequelize/src/instrumentation.ts | 94.89% <94.89%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@seemk - please update the PR with owners according to the contributing guidelines (similar situation as with #2187) if you're still planning to get this instrumentation added. Thanks! 🙂
@seemk - please update the PR with owners according to the contributing guidelines (similar situation as with #2187) if you're still planning to get this instrumentation added. Thanks! 🙂
Updated the PR, but since it has been open for some time I'll go over the semconvs as well
@pichlermarc The PR is up to date with latest semconvs now and I added 2 additional component owners.
This needs to be updated for the new directory structure and reviews from the proposed component owners
This needs to be updated for the new directory structure and reviews from the proposed component owners
Updated
Overall looks good, but it looks like
.tav.yamlis missing which would break test-all-versions onmain- could you please add it? 🙂 I'll add a new label in the meantime so that we can runtest-all-versionson this PR.
And added .tav.yml
With this PR, we can finally replace opentelemetry-instrumentation-sequelize which was still using @opentelemetry/api@ <v1.9.0.
Excellent work, @seemk ! 👏🏻 🎉