opentelemetry-js-contrib
opentelemetry-js-contrib copied to clipboard
fix(instrumentation-knex): Support better-sqlite3 errors
Which problem is this PR solving?
resolves https://github.com/open-telemetry/opentelemetry-js-contrib/issues/2297
Short description of the changes
Make sure better-sqlite3 is supported by not assuming how the error constructor is set up. Adds test accordingly.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.30%. Comparing base (
dfb2dff) to head (c2eb363). Report is 373 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2298 +/- ##
==========================================
- Coverage 90.97% 90.30% -0.67%
==========================================
Files 146 147 +1
Lines 7492 7264 -228
Branches 1502 1509 +7
==========================================
- Hits 6816 6560 -256
- Misses 676 704 +28
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...de/opentelemetry-instrumentation-knex/src/utils.ts | 90.47% <100.00%> (+0.23%) |
:arrow_up: |
@AbhiPrasad I think this could be merged as is, given the approvals. A polite ping on my question above: https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2298#discussion_r1659367963
@AbhiPrasad Also, are you able to update? Your fork repo doesn't allow commits from me so I cannot update the base branch.
@AbhiPrasad and @trentm any news on this PR? Anything I can help with?
Hi, any updates? Can we help?
@deejay1: as @trentm has said, the author @AbhiPrasad is using an organization fork and maintainer edits are off. It's not up-to-date so we cannot merge it (GitHub UI and Org required repo settings prevent this) - it's stuck in limbo until the PR is updated.
@pichlermarc @trentm I merged the current main branch against this branch, added the review suggestion and created a new PR. Of course you can decide to drop my PR, but this issue currently breaks some things I'm working on and it looks like it's one way of going forward with this.
Closing. This was completed in https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2650