opentelemetry-js-contrib
opentelemetry-js-contrib copied to clipboard
feat: typeorm instrumentation
Short description of the changes
Adds the typeorm instrumentation created by Aspecto.
Only contains minor changes: upgraded to the latest SDK and semantic conventions package, modified the tests to use assert, changed the hook type signature.
Codecov Report
Attention: Patch coverage is 90.40404% with 19 lines in your changes missing coverage. Please review.
Project coverage is 89.55%. Comparing base (
1e2db67) to head (71a25ab). Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...lugins/node/instrumentation-typeorm/src/typeorm.ts | 89.20% | 19 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2187 +/- ##
==========================================
+ Coverage 89.53% 89.55% +0.01%
==========================================
Files 174 180 +6
Lines 8521 8719 +198
Branches 1727 1767 +40
==========================================
+ Hits 7629 7808 +179
- Misses 892 911 +19
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...lugins/node/instrumentation-typeorm/src/semconv.ts | 100.00% <100.00%> (ø) |
|
| plugins/node/instrumentation-typeorm/src/types.ts | 100.00% <100.00%> (ø) |
|
| ...entation-typeorm/src/utils/get-func-param-names.ts | 100.00% <100.00%> (ø) |
|
| ...ns/node/instrumentation-typeorm/src/utils/index.ts | 100.00% <100.00%> (ø) |
|
| ...strumentation-typeorm/src/utils/suppressTracing.ts | 100.00% <100.00%> (ø) |
|
| ...lugins/node/instrumentation-typeorm/src/typeorm.ts | 89.20% <89.20%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Thank you for working on this 🙏🎉
Left few comments and suggestions
The original instrumentation had a test-all-versions setup. I wonder if it was left out on purpose or just overlooked.
Overlooked, going to re-add it, thanks!
Briefly messed up a commit and GitHub actions added various tags, shouldn't be a problem
Should've addressed all the feedback now
@blumamir Anything else to resolve here?
@blumamir Up, could you review I could also help with that as I am waiting for proper typeorm instrumentation.
cc @blumamir - I would appreciate you having another look if you find some time 🙂
@pichlermarc Added @t2t2 and @mhennoch as additional component owners, getting more people to help out with JS contrib, especially for the upcoming and/or ported instrumentations.
@seemk conflicts need to be resovled one last time then this is good to merge 🙂
@pichlermarc Thanks, there's one job that failed due to npm ERR! code ECONNRESET, can you trigger a rerun of this?
@pichlermarc Nvm, pushed an empty commit to trigger it