opentelemetry-js-contrib icon indicating copy to clipboard operation
opentelemetry-js-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Support new tedious version 16

Open blumamir opened this issue 2 years ago • 2 comments

Tedious current latest major is 16. Since tedious 16 dropped support for node 14, it makes our CI fail currently.

I attempted to fix that in #1638 in few ways, but they all were dead ends. I am unable to run tests locally as mssql has no docker image version for my Mac Apple chip which means I cannot run tests locally. After a few failed attempts to fix the test via the CI, I decided it was too much for me currently so I documented the task in this issue instead.

blumamir avatar Aug 29 '23 06:08 blumamir

Hey @blumamir, thanks for opening this.

We just upgraded tedious to 16.7.1 and realised that the current instrumentation supports the >=1.11.0 <=15 version range.

I saw you tried to support v16 in the PRs mentioned above. Is there anything I can do to help? I have a Windows machine so the SQL Server image shouldn't be an issue.

Cheers.

mderriey avatar Mar 04 '24 15:03 mderriey

@blumamir @mderriey

I can take this one after https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2144 gets merged :)

david-luna avatar Apr 24 '24 15:04 david-luna

@david-luna That would be nice. If you need any help, let me know.

kirrg001 avatar May 06 '24 10:05 kirrg001

@david-luna Could you please let me know if you want to add the support for v18 after the merge? Otherwise I will do it.

kirrg001 avatar May 22 '24 08:05 kirrg001

@david-luna

@david-luna Could you please let me know if you want to add the support for v18 after the https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2178? Otherwise I will do it.

kirrg001 avatar Jun 03 '24 12:06 kirrg001

https://github.com/open-telemetry/opentelemetry-js-contrib/issues/2266 I will try to add support for v18.

kirrg001 avatar Jun 07 '24 08:06 kirrg001