opentelemetry-java icon indicating copy to clipboard operation
opentelemetry-java copied to clipboard

add scope schema URL and attributes to prom attributes

Open zeitlinger opened this issue 7 months ago • 6 comments

Reference implementation: https://github.com/open-telemetry/opentelemetry-go/pull/5947

Towards https://github.com/open-telemetry/opentelemetry-specification/issues/4223

zeitlinger avatar May 19 '25 17:05 zeitlinger

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.90%. Comparing base (f2f29f5) to head (2edc05f). Report is 54 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7356      +/-   ##
============================================
+ Coverage     89.77%   89.90%   +0.13%     
- Complexity     6982     7011      +29     
============================================
  Files           797      798       +1     
  Lines         21160    21219      +59     
  Branches       2056     2056              
============================================
+ Hits          18996    19078      +82     
+ Misses         1503     1484      -19     
+ Partials        661      657       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 19 '25 17:05 codecov[bot]

@zeitlinger, FYI. From https://github.com/open-telemetry/opentelemetry-go/pull/5947#issuecomment-290203538:

SIG meeting: We agreed that this can be merged before updating the spec given we have a preliminary consent with OTel-Prometheus SIG and both exporter and spec are "development".

pellared avatar May 23 '25 08:05 pellared

@zeitlinger, FYI: open-telemetry/opentelemetry-go#5947 (comment)

from that comment

SIG meeting: We agreed that this can be merged before updating the spec given we have a preliminary consent with OTel-Prometheus SIG and both exporter and spec are "development".

zeitlinger avatar May 23 '25 09:05 zeitlinger

This is just a heads-up that the spec change this PR addresses has already been approved and is about to be merged! So you're good to proceed.

If removing the otel_scope_info metric is a breaking change for your SDK, you're empowered to decide how to roll this out!

ArthurSens avatar Jun 05 '25 13:06 ArthurSens

If removing the otel_scope_info metric is a breaking change for your SDK, you're empowered to decide how to roll this out!

This is not part of this PR - will discuss first how to address this

zeitlinger avatar Jun 05 '25 13:06 zeitlinger

@jack-berg can you take a look?

zeitlinger avatar Jun 12 '25 06:06 zeitlinger

@jack-berg please check again

zeitlinger avatar Jul 10 '25 11:07 zeitlinger