Allow frameworks to add instrumentation scope conditions

[brunobat]

I know the feature is internal, but it's there for 1y now and should be mature enough to be used.

[trask]

@brunobat is there any corresponding incubating or internal API that needs to be deprecated (or was this never exposed at all)?

is test coverage already complete for the feature?

(also, it looks like you need to run ./gradlew jApiCmp)

[brunobat]

Moved to draft. There are some tests but I'm not sure they are thorough. If this can move forward I also need to:

• change javadoc
• delete util classes that allow config by reflection.
• do more tests

[trask]

thanks, I support stabilizing this feature

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.03%. Comparing base (3ef4be2) to head (87c2ba0). Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #7312   +/-   ##
=========================================
  Coverage     90.03%   90.03%           
  Complexity     6915     6915           
=========================================
  Files           787      787           
  Lines         20864    20864           
  Branches       2023     2023           
=========================================
  Hits          18784    18784           
  Misses         1441     1441           
  Partials        639      639           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jack-berg]

Stabilizing this is blocked by the spec. This feature is still "in development" at the spec level: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#tracerconfigurator

[jack-berg]

@brunobat is there any corresponding incubating or internal API that needs to be deprecated (or was this never exposed at all)?

These are available for experimental use via Sdk{Signal}ProviderUtil, e.g. https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/internal/SdkTracerProviderUtil.java#L43-L74

[trask]

Stabilizing this is blocked by the spec. This feature is still "in development" at the spec level: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#tracerconfigurator

thanks, I got mixed up thinking this was about stabilizing instrumentation scope attributes 🙈

[brunobat]

@jack-berg, I guess I need to ask in the spec meeting about the status of the feature you mention.

[trask]

@brunobat go ahead and open a spec issue about stabilizing it, e.g. https://github.com/open-telemetry/opentelemetry-specification/issues?q=is%3Aissue%20state%3Aclosed%20stabilize%20in%3Atitle