opentelemetry-java icon indicating copy to clipboard operation
opentelemetry-java copied to clipboard

Extend prometheus declarative config support to include without_scope_info, with_resource_constant_labels

Open jack-berg opened this issue 1 year ago • 1 comments

From the schema: https://github.com/open-telemetry/opentelemetry-configuration/blob/e196026e6779e180155537f0e7585a379b40a1d3/examples/kitchen-sink.yaml#L93-L108

jack-berg avatar Oct 30 '24 21:10 jack-berg

Codecov Report

Attention: Patch coverage is 92.85714% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.88%. Comparing base (d9c9583) to head (cfaf70a). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...elemetry/sdk/internal/IncludeExcludePredicate.java 92.10% 1 Missing and 2 partials :warning:
...ometheus/internal/PrometheusComponentProvider.java 90.90% 0 Missing and 1 partial :warning:
...dk/extension/incubator/fileconfig/ViewFactory.java 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6840      +/-   ##
============================================
+ Coverage     89.85%   89.88%   +0.02%     
- Complexity     7005     7017      +12     
============================================
  Files           798      799       +1     
  Lines         21211    21240      +29     
  Branches       2055     2065      +10     
============================================
+ Hits          19059    19091      +32     
+ Misses         1493     1488       -5     
- Partials        659      661       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 30 '24 21:10 codecov[bot]

Note this PR was discussed / requested in this discussion: https://github.com/open-telemetry/opentelemetry-java/discussions/7473

If folks can review, I think we should move forward with this PR. Its still valuable and low risk.

jack-berg avatar Jul 08 '25 22:07 jack-berg