opentelemetry-java icon indicating copy to clipboard operation
opentelemetry-java copied to clipboard

Stabilize ExceptionEventData

Open vasantteja opened this issue 1 year ago • 1 comments

This Change

I promoted both the interface and implementation to data package adhering to the package structure inside the internal implementation. Let me know your thoughts. Sorry for opening another pr when we have another pr. This resolves 6630

vasantteja avatar Oct 16 '24 01:10 vasantteja

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.49%. Comparing base (b1cd30e) to head (18c2578). Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
.../main/java/io/opentelemetry/sdk/trace/SdkSpan.java 92.30% 0 Missing and 2 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6795      +/-   ##
============================================
+ Coverage     90.12%   90.49%   +0.37%     
- Complexity     6546     6598      +52     
============================================
  Files           728      731       +3     
  Lines         19702    19735      +33     
  Branches       1935     1938       +3     
============================================
+ Hits          17756    17859     +103     
+ Misses         1347     1283      -64     
+ Partials        599      593       -6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 16 '24 01:10 codecov[bot]

I pushed a small commit to capture the total number of attributes added (in case any were filtered to conform to SpanLimits), and to remove unused methods. Looks good to merge to me!

jack-berg avatar Oct 29 '24 14:10 jack-berg