opentelemetry-java icon indicating copy to clipboard operation
opentelemetry-java copied to clipboard

[OpenTracing Shim] Support TraceFlags-only propagation without parent span

Open ChenX1993 opened this issue 2 years ago • 10 comments

Resolves #5339

Support propagating the TraceFlags without parent spans, e.g. the usecase of jaeger-debug-id.

ChenX1993 avatar Apr 13 '23 08:04 ChenX1993

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: ChenX1993 / name: Chen Xu (e912fe97cb14546072f79533ed183a825c6979b5)

Codecov Report

Patch coverage: 35.71% and project coverage change: -0.11 :warning:

Comparison is base (0a2dd9e) 91.38% compared to head (e912fe9) 91.27%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5380      +/-   ##
============================================
- Coverage     91.38%   91.27%   -0.11%     
- Complexity     4959     4964       +5     
============================================
  Files           549      550       +1     
  Lines         14563    14589      +26     
  Branches       1356     1358       +2     
============================================
+ Hits          13308    13316       +8     
- Misses          868      886      +18     
  Partials        387      387              
Impacted Files Coverage Δ
...y/opentracingshim/PropagatedOpenTelemetrySpan.java 25.00% <25.00%> (ø)
.../io/opentelemetry/opentracingshim/Propagation.java 88.88% <100.00%> (+0.65%) :arrow_up:
...opentelemetry/opentracingshim/SpanBuilderShim.java 94.82% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 13 '23 08:04 codecov[bot]

@carlosalberto Can you take a look? This doesn't seem out-of-line to me, but I really don't know much about OT.

jkwatson avatar Apr 23 '23 21:04 jkwatson

@carlosalberto bump. Does this impact stabilizing the shim in #5371?

jack-berg avatar May 02 '23 15:05 jack-berg

I'd say NO - the reason is that is not covered in the Compatibility spec right now (which is stable already). I will prepare a PR to the Spec to update this condition. My impression is that this shouldn't be impacting the expected behavior (as Jaeger already supported this, and it's a corner case for them).

cc @yurishkuro

carlosalberto avatar May 04 '23 12:05 carlosalberto

(In case I wasn't clear, while I prepare the Spec PR for this, I suggest we don't include this in the upcoming release)

carlosalberto avatar May 04 '23 12:05 carlosalberto

Ping @ChenX1993

carlosalberto avatar May 31 '23 15:05 carlosalberto

Sorry for the late reply. @yurishkuro Thanks for the remind @carlosalberto

ChenX1993 avatar May 31 '23 16:05 ChenX1993

Ping @yurishkuro

carlosalberto avatar Jul 06 '23 15:07 carlosalberto

Ping @yurishkuro

carlosalberto avatar Jul 18 '23 13:07 carlosalberto

Closing this PR as stale. Please re-open if interested in continuing the effort.

jack-berg avatar Apr 04 '24 19:04 jack-berg