opentelemetry-java icon indicating copy to clipboard operation
opentelemetry-java copied to clipboard

Make opentelemetry-bom-alpha depend on opentelemetry-bom

Open jack-berg opened this issue 2 years ago • 1 comments

Resolves #4747.

The resulting pom artifact looks like:

<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <!-- This module was also published with a richer model, Gradle metadata,  -->
  <!-- which should be used instead. Do not delete the following line which  -->
  <!-- is to indicate to Gradle or any Gradle module metadata file consumer  -->
  <!-- that they should prefer consuming it instead. -->
  <!-- do_not_remove: published-with-gradle-metadata -->
  <modelVersion>4.0.0</modelVersion>
  <groupId>io.opentelemetry</groupId>
  <artifactId>opentelemetry-bom-alpha</artifactId>
  <version>1.19.0-alpha-SNAPSHOT</version>
  <packaging>pom</packaging>
  <name>OpenTelemetry Java</name>
  <description>OpenTelemetry Bill of Materials (Alpha)</description>
  <url>https://github.com/open-telemetry/opentelemetry-java</url>
  <licenses>
    <license>
      <name>The Apache License, Version 2.0</name>
      <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
    </license>
  </licenses>
  <developers>
    <developer>
      <id>opentelemetry</id>
      <name>OpenTelemetry</name>
      <url>https://github.com/open-telemetry/community</url>
    </developer>
  </developers>
  <scm>
    <connection>scm:git:[email protected]:open-telemetry/opentelemetry-java.git</connection>
    <developerConnection>scm:git:[email protected]:open-telemetry/opentelemetry-java.git</developerConnection>
    <url>[email protected]:open-telemetry/opentelemetry-java.git</url>
  </scm>
  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>io.opentelemetry</groupId>
        <artifactId>opentelemetry-exporter-otlp-logs</artifactId>
        <version>1.19.0-alpha-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>io.opentelemetry</groupId>
        <artifactId>opentelemetry-bom</artifactId>
        <version>1.19.0-SNAPSHOT</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>
</project>

Notice the dependency of opentelemetry-bom is type=pom, which means that it should be replaced by dependencies in its bom. I tested this locally and was able to place a dependency on io.opentelemetry:opentelemetry-bom-alpha:<version> and have versions managed for both stable and alpha artifacts.

jack-berg avatar Sep 13 '22 20:09 jack-berg

Codecov Report

Base: 90.77% // Head: 90.77% // No change to project coverage :thumbsup:

Coverage data is based on head (92c0c4c) compared to base (cdab465). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4755   +/-   ##
=========================================
  Coverage     90.77%   90.77%           
  Complexity     4814     4814           
=========================================
  Files           551      551           
  Lines         14356    14356           
  Branches       1395     1395           
=========================================
  Hits          13031    13031           
  Misses          909      909           
  Partials        416      416           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 13 '22 21:09 codecov[bot]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Sep 28 '22 09:09 github-actions[bot]