opentelemetry-java icon indicating copy to clipboard operation
opentelemetry-java copied to clipboard

Implement aws.ecs.* resource attributes

Open mmanciop opened this issue 1 year ago • 3 comments

Add to io.opentelemetry.sdk.extension.aws.resource.EcsResource the logic to detect the aws.ecs.* resource attributes using data from the Amazon ECS Metadata v4 endpoint.

mmanciop avatar Aug 05 '22 13:08 mmanciop

Codecov Report

Merging #4670 (360c5d8) into main (4bfe17f) will decrease coverage by 0.01%. The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4670      +/-   ##
============================================
- Coverage     90.13%   90.12%   -0.02%     
  Complexity     5069     5069              
============================================
  Files           584      584              
  Lines         15649    15649              
  Branches       1503     1503              
============================================
- Hits          14106    14103       -3     
- Misses         1091     1092       +1     
- Partials        452      454       +2     
Impacted Files Coverage Δ
...metry/sdk/metrics/export/PeriodicMetricReader.java 87.14% <0.00%> (-2.86%) :arrow_down:
...entelemetry/sdk/logs/export/BatchLogProcessor.java 88.72% <0.00%> (-0.76%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 05 '22 13:08 codecov[bot]

@jeromeinsf could you help us find someone from AWS that could review this PR?

trask avatar Aug 05 '22 18:08 trask

@willarmiros Can you review this?

jkwatson avatar Aug 05 '22 23:08 jkwatson

Correct me if I'm wrong, but this appears to be a subset of #4574. I believe the other PR adds all of the attributes added by this one and more? If so, would you be amenable to closing this PR as a duplicate of #4574 @mmanciop?

willarmiros avatar Aug 09 '22 15:08 willarmiros

@willarmiros #4574 does not implement AWS_ECS_LAUNCHTYPE but for the rest yes, it is a superset and I'd be OK closing mine as duplicate

mmanciop avatar Aug 09 '22 19:08 mmanciop