opentelemetry-java icon indicating copy to clipboard operation
opentelemetry-java copied to clipboard

Add option in BatchSpanProcessor to support multiple pending exports

Open trask opened this issue 2 years ago • 4 comments

Resolves #4264

This is a third option that I like better than both #4245 and #4246.

trask avatar Mar 20 '22 03:03 trask

Codecov Report

Merging #4280 (1ccf507) into main (14ffacd) will increase coverage by 0.00%. The diff coverage is 95.65%.

@@            Coverage Diff            @@
##               main    #4280   +/-   ##
=========================================
  Coverage     89.88%   89.88%           
- Complexity     4844     4847    +3     
=========================================
  Files           568      568           
  Lines         15063    15081   +18     
  Branches       1427     1429    +2     
=========================================
+ Hits          13539    13556   +17     
  Misses         1060     1060           
- Partials        464      465    +1     
Impacted Files Coverage Δ
...ry/sdk/trace/export/BatchSpanProcessorBuilder.java 94.73% <80.00%> (-2.24%) :arrow_down:
...telemetry/sdk/trace/export/BatchSpanProcessor.java 91.02% <100.00%> (+0.11%) :arrow_up:
...pentelemetry/sdk/common/CompletableResultCode.java 100.00% <0.00%> (+1.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14ffacd...1ccf507. Read the comment docs.

codecov[bot] avatar Mar 20 '22 04:03 codecov[bot]

discussed with @anuraaga, I'm not in a rush for this change, will open a spec issue to discuss adding this setting to the spec

trask avatar Mar 22 '22 05:03 trask

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Jun 22 '22 19:06 github-actions[bot]

@open-telemetry/java-maintainers can you apply the prototype label to this (if you agree)?

trask avatar Jun 22 '22 19:06 trask