open-telemetry
Remove declarative config bridge from agent
I think we need to keep this bridge until we remove the deprecated methods that are still using ConfigProperties
I think we need to keep this bridge until we remove the deprecated methods that are still using ConfigProperties
No those are not using this bridge - use explicit fallback instead.
In fact, only contrib extensions use this bridge at this point.
what if someone has an extension with
- IgnoredTypesConfigurer
- InstrumentationModule
using one of those deprecated ConfigProperties methods?
what if someone has an extension with
- IgnoredTypesConfigurer
- InstrumentationModule
using one of those deprecated ConfigProperties methods?
That's a good point. We have to decide if we want to support ConfigProperties in those extensions together with declarative config, which is still experimental. I would say we sholudn't try to do that, it only creates some things that still don't work - like the new "distribution" node support added in https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/15822.
I would say we shouldn't try to do that, it only creates some things that still don't work
good point, extensions (e.g. adding span processors) generally need to do work anyways to support declarative configuration