opentelemetry-java-contrib
opentelemetry-java-contrib copied to clipboard
Initial update of JMX's Kafka metrics.
PR with the upcoming changes from https://github.com/open-telemetry/opentelemetry-specification/pull/2485 - observe not all metrics are included, namely:
- Metrics which could use Summary points instead (changes have been postponed)
- Consumer metrics (follow up required)
- ALL metrics now have a
messaging
prefix, in order to comply with the tracing semantic conventions.
Please review @dehaansa @rmfitzpatrick
@rmfitzpatrick @dehaansa Please review, as the actual Specification has been updated.
I'm getting failed checks because of this, which is not related to the changes themselves. Any idea?
Task :static-instrumenter:agent-extension:compileJava
/home/runner/work/opentelemetry-java-contrib/opentelemetry-java-contrib/static-instrumenter/agent-extension/src/main/java/io/opentelemetry/contrib/staticinstrumenter/extension/AdditionalClassesInjectorListenerInstaller.java:23: warning: [deprecation] beforeAgent(Config,AutoConfiguredOpenTelemetrySdk) in AgentListener has been deprecated
public void beforeAgent(
^
error: warnings found and -Werror specified
1 error
1 warning
I'm getting failed checks because of this, which is not related to the changes themselves. Any idea?
Task :static-instrumenter:agent-extension:compileJava /home/runner/work/opentelemetry-java-contrib/opentelemetry-java-contrib/static-instrumenter/agent-extension/src/main/java/io/opentelemetry/contrib/staticinstrumenter/extension/AdditionalClassesInjectorListenerInstaller.java:23: warning: [deprecation] beforeAgent(Config,AutoConfiguredOpenTelemetrySdk) in AgentListener has been deprecated public void beforeAgent( ^ error: warnings found and -Werror specified 1 error 1 warning
@carlosalberto hopefully fixed, try rebasing
@laurit Awesome, thanks! Done.
Thanks for driving the spec updates and these changes, which look great. Do you mind updating the existing readmes, maybe linking to the spec for the producer and general metrics to reduce c/p?
@rmfitzpatrick Are they auto generated? I'm guessing that's a NO? Updating them manually doesn't sound very fun, etc.
@rmfitzpatrick Are they auto generated? I'm guessing that's a NO? Updating them manually doesn't sound very fun, etc.
Right, we don't have a metadata scheme/docs generator for the project atm. That would be a nice enhancement.
I saw 1.14 was just released - so it means one more month to go with the out of date metrics, right?
(And yes, the docs should be autogenerated - it's enough pain to update them in the code and tests, and then go through that in the docs as well).
@carlosalberto also are you still working on this? thx
This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.