opentelemetry-helm-charts icon indicating copy to clipboard operation
opentelemetry-helm-charts copied to clipboard

Enable the K8s attribute processor

Open martinjt opened this issue 1 year ago • 3 comments

It would be great if the attribute processor was included and configured by default. This would mean that all the spans get a tonne of extra k8s information like pods, start times etc. that allows us to showcase a lot of the benefits of the collector and k8s and also tracing/metrics correlation.

martinjt avatar Apr 05 '23 13:04 martinjt

@martinjt the k8sattributes processor has RBAC permissions that aren't suitable for a default install of the collector, but we do have the k8sattributes processor as a preset. You can do

mode: daemonset
presets:
  kubernetesAttributes:
    enabled: true

and it will be added to the configuration for you and all the necessary changes will be made to the clusterrole/clusterrolebinding.

TylerHelmuth avatar Apr 05 '23 14:04 TylerHelmuth

Should the demo include this preset by default?

puckpuck avatar Apr 06 '23 00:04 puckpuck

Enabling this preset by default would require installing the clusterRole and clusterRoleBinding which, in my opinion, aren't appropriate for a default install. We should keep the default version of the chart as accessible as possible for any user who wants to try out the collector.

TylerHelmuth avatar Apr 06 '23 01:04 TylerHelmuth