Support configuring and disabling healthcheck extension

[jsirianni]

The healthcheck probes are configured like this, without customization options.

    livenessProbe:
      httpGet:
        path: /
        port: 13133
    readinessProbe:
      httpGet:
        path: /
        port: 13133

I would like the following options

• ability to change path, port
• ability to set other options like periodSeconds
• ability to disable healthcheck extension all together.

While I agree that generally healthcheck extension + healthcheck probes should always be in use, I do think this should be up to the user. I think defaulting to the current configuration (enabled with sane defaults) is great.

I would be willing to take on this work if the community agrees.

[TylerHelmuth]

@jsirianni this topic has come up before, here is the related issue for context: https://github.com/open-telemetry/opentelemetry-helm-charts/issues/242

[TylerHelmuth]

Do you have a use case in mind that requires more configurability to the readiness and liveness sections?

[jsirianni]

Thanks for linking that. I am not sure I agree with the statement that health checks are mandatory in k8s, but I do agree that they are highly recommended. My argument has already been discussed there by the OP, so I can concede. It does feel "forced" but I understand the reasoning.

I do not have a concrete usecase, but I can imagine wanting to dial in probe settings for a service that might be scaling up and down frequently. To me, this was less important than having the ability to disable the checks.

If the stanza to absolutely always require the healthcheck extension, feel free to close this issue.

[lewis-prior-thrivent]

I'd like to see the ability to extend the health check timeout as if you have a big configuration with a lot of processors it can take a while for the collector to report back healthy causing issues causing restarts again.

[TylerHelmuth]

Being able to configure these options sounds like a good idea.

[TylerHelmuth]

Being able to configure ports is also acceptable.

[jmichalek132]

Hi, would it be possible to also add option to disable readiness / liveness probe? At times I need to debug the otel collector using the delve debugger and I usually ran into the pod I am attached to getting killed by the liveness probe (when you pause the process, the liveness probe is not responding), forcing me to copy the helm chart and remove the liveness probe.