set proper resources for collector

[markandersontrocme]

Closes #272

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: MarkAndersonTrocme / name: Mark Anderson-Trocme (9177389cdf01605105fc1b4f0000faee8c3e8d65)

[Allex1]

@MarkAndersonTrocme pls bump the chart version. Also I would tend to give a bit more memory for limits.

[markandersontrocme]

@Allex1 Let me know if those resources make more sense now? If not let me know what you recommend

[TylerHelmuth]

@dmitryax @MarkAndersonTrocme @Allex1 I support this change but I think its a "breaking change". Some customers may be relying on the higher default values and if they upgraded to this version their requests/limits would get halved. Any ideas on how we can handle that gracefully?

[Allex1]

We increase the minor version and maybe update the main Readme with a warning? While the chart suggests sensible defaults users are responsible for setting their own resource allocation values. Also users should expect some imminent breaking changes as the chart is not yet stable. Once it's stable we could increase the major version when making breaking changes and document the upgrade path on our main Readme. wdyt?

[TylerHelmuth]

Ya without a major version I can't think of a good way to handle this without introducing a new field, which I don't really want to do. We do have an UPGRADING.md doc that feels like a good place to callout this change. @MarkAndersonTrocme can you add a new entry in UPGRADING.md that calls out this change and shows readers how to set the values back to the old values?

[TylerHelmuth]

@MarkAndersonTrocme please handle merge conflicts.

[github-actions[bot]]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[github-actions[bot]]

Closed as inactive. Feel free to reopen if this PR is still being worked on.

[Allex1]

@TylerHelmuth @dmitryax I've reopened this as I think it's useful to set lower sensible defaults. PTAL