opentelemetry-helm-charts icon indicating copy to clipboard operation
opentelemetry-helm-charts copied to clipboard

[Operator] Delete collector image version from the values.yaml

Open jdiegosierra opened this issue 9 months ago • 8 comments

Hello,

I noticed that currently .Chart.AppVersion is the default value for the opentelemetry-operator.image https://github.com/open-telemetry/opentelemetry-helm-charts/blob/2f4e7a8f960366b961d621c9bc7c6ae389129af3/charts/opentelemetry-operator/templates/_helpers.tpl#L150

Keeping in mind that the operator and the collector should have the same version https://github.com/open-telemetry/opentelemetry-operator?tab=readme-ov-file#opentelemetry-operator-vs-opentelemetry-collector.

Why not using appVersion as default for collectorImage as well?

Or simply why the values.yaml has the collector image set? https://github.com/open-telemetry/opentelemetry-helm-charts/blob/2f4e7a8f960366b961d621c9bc7c6ae389129af3/charts/opentelemetry-operator/values.yaml#L45

If I'm not wrong, if we don't set the --collector-image flag https://github.com/open-telemetry/opentelemetry-helm-charts/blob/2f4e7a8f960366b961d621c9bc7c6ae389129af3/charts/opentelemetry-operator/templates/deployment.yaml#L51 The operator will take care of deploying a collector with the same version as itself, isn't it? So why is needed to set a value for the collector by default?

jdiegosierra avatar May 17 '24 10:05 jdiegosierra