opentelemetry-helm-charts icon indicating copy to clipboard operation
opentelemetry-helm-charts copied to clipboard

Allow to configure a local and global image registry

Open aacevedoosorio opened this issue 1 year ago • 4 comments

Handy when you have specific security requirements that prevent you from using a public image registry

aacevedoosorio avatar Jan 31 '24 12:01 aacevedoosorio

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: aacevedoosorio / name: Alejandro Acevedo (3a60ca1c5aa12d1521c8003d76a06ad3a5b21ab8, 87a336a4144da2d0ec0a96c66c59f923e498eb43, 3cdf4fe576187baab0daa5175af3825fdccd8b9e, 1337e1e94439cd609642591bc2a13fe5212757fe, 31b77b26d9252ede5e0fde1306d1684aa667d9dc, ceef7b4293725fd15cd77e36486044f0459a224a, 26e5eb38d9fab96d2768fe1076985b002343de0c, 9055152db178f719dbd8b53fee4ea8625c65e918)
  • :white_check_mark: login: TylerHelmuth / name: Tyler Helmuth (03e80360c7b63096a891583f961647420fa81515, 535e2f5c1fdffb61c739efd7f6b0c40f20d00cdf)

@aacevedoosorio thx, pls bump up the chart version by following CONTRIBUTING docs

JaredTan95 avatar Jan 31 '24 13:01 JaredTan95

Question, why do we need global.imageRegistry? Why can't you set the .image.registry directly?

Also is this standard helm chart convention?

povilasv avatar Jan 31 '24 13:01 povilasv

Question, why do we need global.imageRegistry? Why can't you set the .image.registry directly?

Also is this standard helm chart convention?

I have found this convention used on bitnami helm charts and by setting the global.imageRegistry you automatically set all images to be downloaded from that registry rather than having to override .image.registry in several places. E.g. https://github.com/bitnami/charts/blob/main/bitnami/clickhouse/values.yaml#L15

aacevedoosorio avatar Jan 31 '24 17:01 aacevedoosorio

Please bump the chart patch version and run make generate-examples CHARTS=opentelemetry-collector

TylerHelmuth avatar Feb 14 '24 15:02 TylerHelmuth

Please bump the chart patch version and run make generate-examples CHARTS=opentelemetry-collector

 opentelemetry-collector => (version: "0.80.1", path: "charts/opentelemetry-collector") > chart version not ok. Needs a version bump! 

new version bump?

aacevedoosorio avatar Feb 14 '24 15:02 aacevedoosorio

new version bump?

Looks like you took care of it

TylerHelmuth avatar Feb 14 '24 16:02 TylerHelmuth