opentelemetry-go icon indicating copy to clipboard operation
opentelemetry-go copied to clipboard

Test logging from a span in the `opentracing` bridge

Open MrAlias opened this issue 8 months ago • 2 comments

Based on the chaining of how logging works this needs to also fully test the functionality of:

  • LogEvent
  • LogEventWithPayload
  • Log

https://github.com/open-telemetry/opentelemetry-go/blob/b98dd5e5aca263c50154bbb4b58b9254e5821460/bridge/opentracing/bridge.go#L258-L273

MrAlias avatar Mar 27 '25 00:03 MrAlias

@MrAlias , can I take this one?

tongoss avatar Mar 31 '25 22:03 tongoss

@MrAlias , I just notice that these 3 functions have been deprecated, so I just want to confirm whether we still want to add testing?

Image

tongoss avatar Apr 06 '25 14:04 tongoss

@tongoss, I think it is worth to add the tests given that the module is stable so we are not going to remove these functions.

pellared avatar Jun 17 '25 13:06 pellared

@tongoss, I think it is worth to add the tests given that the module is stable so we are not going to remove these functions.

@pellared , Thanks for the guidance. I will raise PR soon.

tongoss avatar Jun 17 '25 13:06 tongoss

Fixed by https://github.com/open-telemetry/opentelemetry-go/pull/6919

pellared avatar Jul 11 '25 08:07 pellared