opentelemetry-go
opentelemetry-go copied to clipboard
Test logging from a span in the `opentracing` bridge
Based on the chaining of how logging works this needs to also fully test the functionality of:
LogEventLogEventWithPayloadLog
https://github.com/open-telemetry/opentelemetry-go/blob/b98dd5e5aca263c50154bbb4b58b9254e5821460/bridge/opentracing/bridge.go#L258-L273
@MrAlias , can I take this one?
@MrAlias , I just notice that these 3 functions have been deprecated, so I just want to confirm whether we still want to add testing?
@tongoss, I think it is worth to add the tests given that the module is stable so we are not going to remove these functions.
@tongoss, I think it is worth to add the tests given that the module is stable so we are not going to remove these functions.
@pellared , Thanks for the guidance. I will raise PR soon.
Fixed by https://github.com/open-telemetry/opentelemetry-go/pull/6919