opentelemetry-go
opentelemetry-go copied to clipboard
Published
20 hours ago •
open-telemetry
open-telemetry
[Spike] sdk/log: Change FilterProcessor to Filterer
Towards https://github.com/open-telemetry/opentelemetry-specification/issues/4207
Based on Proposal B
This is another idea of implementing filtering to the Logs SDK.
I think this design is more in the spirit of the specification and current SDK design. The initial implementation of Enabled was designed when wrapping processors was also needed for implementing log record mutations during processing as log records were passed by value (and not by pointer).
This approach should make adding custom filtering easier for the users in most cases (see the updated ExampleFilterer).
There is a little (mostly CPU) performance overhead caused by looping over filterers in logger.Emit, but I do not find it significant.
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/sdk/log
cpu: Intel(R) Core(TM) i9-10885H CPU @ 2.40GHz
│ old.txt │ new.txt │
│ sec/op │ sec/op vs base │
BatchProcessorOnEmit-16 286.6n ± 9% 402.6n ± 9% +40.43% (p=0.000 n=10)
Processor/Simple-16 689.4n ± 5% 1018.0n ± 31% +47.65% (p=0.000 n=10)
Processor/Batch-16 1.301µ ± 11% 1.643µ ± 21% +26.29% (p=0.000 n=10)
Processor/SetTimestampSimple-16 680.9n ± 2% 884.5n ± 8% +29.88% (p=0.000 n=10)
Processor/SetTimestampBatch-16 1.250µ ± 3% 1.597µ ± 8% +27.76% (p=0.000 n=10)
Processor/AddAttributesSimple-16 784.1n ± 4% 953.4n ± 3% +21.58% (p=0.000 n=10)
Processor/AddAttributesBatch-16 1.453µ ± 5% 1.712µ ± 5% +17.79% (p=0.000 n=10)
Processor/SetAttributesSimple-16 743.6n ± 7% 971.8n ± 10% +30.70% (p=0.000 n=10)
Processor/SetAttributesBatch-16 1.392µ ± 3% 1.409µ ± 33% ~ (p=0.352 n=10)
LoggerNewRecord/5_attributes-16 288.9n ± 3% 283.3n ± 7% ~ (p=0.739 n=10)
LoggerNewRecord/10_attributes-16 1.290µ ± 3% 1.253µ ± 13% ~ (p=0.393 n=10)
LoggerEnabled-16 7.062n ± 10% 4.029n ± 7% -42.96% (p=0.000 n=10)
LoggerProviderLogger-16 593.8n ± 3% 626.7n ± 5% +5.55% (p=0.001 n=10)
WalkAttributes/1_attributes-16 4.665n ± 7% 4.415n ± 3% -5.35% (p=0.035 n=10)
WalkAttributes/10_attributes-16 4.951n ± 11% 4.311n ± 1% -12.93% (p=0.000 n=10)
WalkAttributes/100_attributes-16 4.668n ± 10% 4.275n ± 1% -8.42% (p=0.000 n=10)
WalkAttributes/1000_attributes-16 4.859n ± 4% 4.283n ± 1% -11.85% (p=0.000 n=10)
SetAddAttributes/SetAttributes-16 169.4n ± 7% 173.4n ± 9% ~ (p=0.363 n=10)
SetAddAttributes/AddAttributes-16 118.7n ± 1% 121.4n ± 19% +2.27% (p=0.001 n=10)
SimpleProcessorOnEmit-16 1.764n ± 12% 1.732n ± 8% ~ (p=0.353 n=10)
geomean 139.2n 147.6n +6.03%
│ old.txt │ new.txt │
│ B/s │ B/s vs base │
BatchProcessorOnEmit-16 106.47Mi ± 8% 75.84Mi ± 9% -28.77% (p=0.000 n=10)
│ old.txt │ new.txt │
│ B/op │ B/op vs base │
BatchProcessorOnEmit-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
Processor/Simple-16 417.0 ± 0% 417.0 ± 0% ~ (p=1.000 n=10) ¹
Processor/Batch-16 1.079Ki ± 1% 1.075Ki ± 1% ~ (p=0.643 n=10)
Processor/SetTimestampSimple-16 417.0 ± 0% 417.0 ± 0% ~ (p=1.000 n=10) ¹
Processor/SetTimestampBatch-16 1.074Ki ± 1% 1.077Ki ± 1% ~ (p=0.210 n=10)
Processor/AddAttributesSimple-16 417.0 ± 0% 417.0 ± 0% ~ (p=1.000 n=10) ¹
Processor/AddAttributesBatch-16 1.063Ki ± 1% 1.075Ki ± 1% ~ (p=0.117 n=10)
Processor/SetAttributesSimple-16 465.0 ± 0% 465.0 ± 0% ~ (p=1.000 n=10) ¹
Processor/SetAttributesBatch-16 1.099Ki ± 1% 1.109Ki ± 1% ~ (p=0.060 n=10)
LoggerNewRecord/5_attributes-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
LoggerNewRecord/10_attributes-16 610.0 ± 0% 610.0 ± 0% ~ (p=1.000 n=10) ¹
LoggerEnabled-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
LoggerProviderLogger-16 345.5 ± 6% 365.0 ± 5% +5.64% (p=0.007 n=10)
WalkAttributes/1_attributes-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
WalkAttributes/10_attributes-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
WalkAttributes/100_attributes-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
WalkAttributes/1000_attributes-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
SetAddAttributes/SetAttributes-16 48.00 ± 0% 48.00 ± 0% ~ (p=1.000 n=10) ¹
SetAddAttributes/AddAttributes-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
SimpleProcessorOnEmit-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
geomean ² +0.38% ²
¹ all samples are equal
² summaries must be >0 to compute geomean
│ old.txt │ new.txt │
│ allocs/op │ allocs/op vs base │
BatchProcessorOnEmit-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
Processor/Simple-16 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹
Processor/Batch-16 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹
Processor/SetTimestampSimple-16 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹
Processor/SetTimestampBatch-16 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹
Processor/AddAttributesSimple-16 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹
Processor/AddAttributesBatch-16 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹
Processor/SetAttributesSimple-16 2.000 ± 0% 2.000 ± 0% ~ (p=1.000 n=10) ¹
Processor/SetAttributesBatch-16 2.000 ± 0% 2.000 ± 0% ~ (p=1.000 n=10) ¹
LoggerNewRecord/5_attributes-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
LoggerNewRecord/10_attributes-16 4.000 ± 0% 4.000 ± 0% ~ (p=1.000 n=10) ¹
LoggerEnabled-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
LoggerProviderLogger-16 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹
WalkAttributes/1_attributes-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
WalkAttributes/10_attributes-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
WalkAttributes/100_attributes-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
WalkAttributes/1000_attributes-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
SetAddAttributes/SetAttributes-16 1.000 ± 0% 1.000 ± 0% ~ (p=1.000 n=10) ¹
SetAddAttributes/AddAttributes-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
SimpleProcessorOnEmit-16 0.000 ± 0% 0.000 ± 0% ~ (p=1.000 n=10) ¹
geomean ² +0.00% ²
¹ all samples are equal
² summaries must be >0 to compute geomean
