opentelemetry-go icon indicating copy to clipboard operation
opentelemetry-go copied to clipboard

Move examples to contrib

Open pellared opened this issue 1 year ago • 3 comments

~~A follow-up after https://github.com/open-telemetry/opentelemetry-go/pull/5791 in contrib is required and afterwards here we need to fix the example/dice.~~

  • [x] Copy all example(s) to contrib
    • We should not version the copied examples. They can just be git hash referenced.
    • https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6158
    • https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6160
  • [x] Revert example/dice changes from https://github.com/open-telemetry/opentelemetry-go/pull/5791 so that it uses otelslog.
    • https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6162
  • [x] Deprecate the examples in core repo
    • https://github.com/open-telemetry/opentelemetry-go/pull/5854
  • [ ] RELEASE
  • [ ] Remove the examples from core repo
  • [ ] Update examples otel.io to target contrib repo (instead of core)

pellared avatar Sep 10 '24 16:09 pellared

This round-about dependency seems like something we should address. Should this example be moved to contrib? Should all examples?

MrAlias avatar Sep 11 '24 16:09 MrAlias

This round-about dependency seems like something we should address. Should this example be moved to contrib?

It makes sense also because this example also uses go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp

Should all examples?

It may be indeed easier to keep all examples in contrib.

pellared avatar Sep 12 '24 06:09 pellared

I'm OK with moving examples to contrib

dashpole avatar Sep 12 '24 17:09 dashpole