opentelemetry-go
opentelemetry-go copied to clipboard
Move examples to contrib
~~A follow-up after https://github.com/open-telemetry/opentelemetry-go/pull/5791 in contrib is required and afterwards here we need to fix the example/dice.~~
- [x] Copy all example(s) to contrib
- We should not version the copied examples. They can just be git hash referenced.
- https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6158
- https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6160
- [x] Revert
example/dicechanges from https://github.com/open-telemetry/opentelemetry-go/pull/5791 so that it usesotelslog.- https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6162
- [x] Deprecate the examples in core repo
- https://github.com/open-telemetry/opentelemetry-go/pull/5854
- [ ] RELEASE
- [ ] Remove the examples from core repo
- [ ] Update examples otel.io to target contrib repo (instead of core)
This round-about dependency seems like something we should address. Should this example be moved to contrib? Should all examples?
This round-about dependency seems like something we should address. Should this example be moved to contrib?
It makes sense also because this example also uses go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp
Should all examples?
It may be indeed easier to keep all examples in contrib.
I'm OK with moving examples to contrib