Parse errormsgs in retryable status codes
@MrAlias PR #5537 had incorrect email address, that's why CLA was failing in order to fix it I have to change git history, which is not recommended in contribution guidelines so created this new PR and closing the old one.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.4%. Comparing base (
30cc379) to head (cd4a639).
Additional details and impacted files
@@ Coverage Diff @@
## main #5541 +/- ##
=======================================
- Coverage 84.5% 84.4% -0.1%
=======================================
Files 272 272
Lines 22427 22506 +79
=======================================
+ Hits 18970 19017 +47
- Misses 3124 3153 +29
- Partials 333 336 +3
@dmathieu Is there anything missing/incorrect in this PR that needs a fix? Happy to accomodate that.
@dmathieu Added the error message handling in traces and logs also.
@dmathieu is there anything pending on my end for this PR? If not, will wait for it to merge.
There is a conflict that should be easily resolvable. And a merge requires 2 approvals.
@dmathieu thanks, fixed merge conflicts. Tagging other reviewers for approval.
@pellared @MrAlias @XSAM @dashpole can you please help in reviewing/approving this PR? It will be a big help in solving this issue https://github.com/open-telemetry/opentelemetry-go/issues/5536
@pellared Can you please help in reviewing/approving this? We have customers using otel via http and this PR will help in debugging pipeline issues as it solves https://github.com/open-telemetry/opentelemetry-go/issues/5536 . Sorry for this but it will be a great help.
@dmathieu PTAL.
CI is failing after this merge (for some reason, it didn't fail before, so that may be a flake). https://github.com/open-telemetry/opentelemetry-go/actions/runs/9987613497/job/27602574063
@dmathieu
CI is failing after this merge (for some reason, it didn't fail before, so that may be a flake). https://github.com/open-telemetry/opentelemetry-go/actions/runs/9987613497/job/27602574063
Yes, I also noticed this, it passed earlier. Looks like flaky.
@MrAlias @dmathieu Thank you for helping and guiding throughout the issue, appreciate it.