opentelemetry-go icon indicating copy to clipboard operation
opentelemetry-go copied to clipboard

log/sdk: Add benchmarks

Open pellared opened this issue 1 year ago • 1 comments

pellared avatar Mar 13 '24 08:03 pellared

From SIG meeting: this looks almost complete. @dmathieu plans to another audit and review all coverage.

MrAlias avatar Jun 27 '24 16:06 MrAlias

From the public SDK methods, we are now benchmarking:

  • Record.WalkAttributes()
  • Record.SetAttributes
  • Record.AddAttributes
  • LoggerProvider.Logger
  • logger.newRecord
  • SimpleProcessor.OnEmit
  • BatchProcessor.OnEmit
  • Create a record, with body, severity, attributes, and run SimpleProcessor.OnEmit
  • Create a record, with body, severity, attributes, and run BatchProcessor.OnEmit
  • Create a record, with body, severity, attributes, modify the observed timestamp and run SimpleProcessor.OnEmit
  • Create a record, with body, severity, attributes, modify the observed timestamp and run BatchProcessor.OnEmit

At this stage, all hot public APIs appear to be benchmarked in the log SDK. I believe this issue can be closed.

dmathieu avatar Jul 02 '24 09:07 dmathieu

We can always add more benchmarks later. Great job.

pellared avatar Jul 02 '24 14:07 pellared