opentelemetry-go icon indicating copy to clipboard operation
opentelemetry-go copied to clipboard

Deinal of metric collection via adversiral callback registration.

Open MadVikingGod opened this issue 2 years ago • 1 comments

Description

If there is an error reported in any callback function no

Environment

tested with, but should apply to all

  • OS: linx
  • Architecture: amd64
  • Go Version: 1.19.4
  • opentelemetry-go version: v1.13.0/v.0.36.0

Steps To Reproduce

The example provided has two different "libraries" one for single callback and another for multicallback. Both only return an error. This behavior will happen for any callback that errors.

  1. clone example project: https://github.com/MadVikingGod/adversirial-callback
  2. run, this should have a populated Resource Metric printed
  3. uncomment either import
  4. run, This won't have any metrics printed.

Expected behavior

In the example above importing a callback which errors should not prevent other metrics from being reported.

MadVikingGod avatar Feb 17 '23 15:02 MadVikingGod

Hey @MadVikingGod

I can't reproduce this with v1.14.0/v.0.37.0

It seems this has been resolved already with PR #3732

But I can work on it if we still want to patch version v1.13.0/v.0.36.0

unicod3 avatar Mar 01 '23 22:03 unicod3