opentelemetry-go icon indicating copy to clipboard operation
opentelemetry-go copied to clipboard

insecure default otlp exporter example

Open Petrie opened this issue 2 years ago • 1 comments

What am i trying to do

First , I run a jaeger instance with config in the lastest jaeger getting started doc , as follows:

docker run -d --name jaeger \
  -e COLLECTOR_ZIPKIN_HOST_PORT=:9411 \
  -e COLLECTOR_OTLP_ENABLED=true \
  -p 6831:6831/udp \
  -p 6832:6832/udp \
  -p 5778:5778 \
  -p 16686:16686 \
  -p 4317:4317 \
  -p 4318:4318 \
  -p 14250:14250 \
  -p 14268:14268 \
  -p 14269:14269 \
  -p 9411:9411 \
  jaegertracing/all-in-one:1.37

I try run the example to send some test Trace info to jaeger directly.

Problems encountered

After I run example code, there's no Trace info in Jaeger UI

My adjustment

I check the exporter API, and find WithInsecure option. After add WithInsecure option, example code send data success.

Overall

I think add WithInsecure option to exporter client is more newbie friendly.

Petrie avatar Aug 29 '22 15:08 Petrie

Hi , Thanks for the quick response, below is what I would like to add

In specification for exporter , I find:

SDKs SHOULD default endpoint variables to use http scheme unless they have good reasons to choose https scheme for the default (e.g., for backward compatibility reasons in a stable SDK release).

This instruction emphasizes the use of http instead of https by default. I don't know original intent of this instruction. but I guess it'll more friendly with this instruction. Same as this example. audience of this example are often new. we should consider newbie friendly more. Apply to both:http and gRPC.

In my own opinion, exampe is a quickstart for new users, rather than production’s guide.

PTAL @MrAlias Best wishes!

Petrie avatar Sep 02 '22 09:09 Petrie