opentelemetry-go icon indicating copy to clipboard operation
opentelemetry-go copied to clipboard

golangci lint fix

Open Petrie opened this issue 2 years ago • 4 comments

Petrie avatar Jun 29 '22 01:06 Petrie

Codecov Report

Merging #2985 (71ee3c9) into main (eb55e60) will increase coverage by 0.0%. The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2985   +/-   ##
=====================================
  Coverage   76.2%   76.2%           
=====================================
  Files        179     179           
  Lines      11939   11939           
=====================================
+ Hits        9103    9105    +2     
+ Misses      2596    2594    -2     
  Partials     240     240           
Impacted Files Coverage Δ
sdk/trace/provider.go 85.5% <100.0%> (ø)
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) :arrow_up:

codecov[bot] avatar Jun 29 '22 01:06 codecov[bot]

Is there a golangci config we should change so those issues fail the CI is they happen again?

dmathieu avatar Jun 29 '22 08:06 dmathieu

Is there a golangci config we should change so those issues fail the CI is they happen again?

I'll try to solve this.

Petrie avatar Jun 29 '22 10:06 Petrie

I open a new pr https://github.com/open-telemetry/opentelemetry-go/pull/2987 to fix this lint error. with fix the CI exec abnormal phenomenon.

Petrie avatar Jun 30 '22 00:06 Petrie

Is this still needed?

MrAlias avatar Oct 27 '22 21:10 MrAlias