DRAFT: Change the inclusivity of exponential histogram bounds
The Prometheus project is strongly opposed to the use of lower-inclusive boundaries and has requested that OpenTelemetry change its position. This is the implied change, for demonstration.
This is not meant to be reviewed without the accompanying proposal, please follow https://github.com/open-telemetry/opentelemetry-specification/issues/2611.
Codecov Report
Merging #2982 (db67882) into main (8c3a85a) will increase coverage by
0.0%. The diff coverage is100.0%.
@@ Coverage Diff @@
## main #2982 +/- ##
=====================================
Coverage 76.2% 76.3%
=====================================
Files 179 179
Lines 11942 11950 +8
=====================================
+ Hits 9110 9118 +8
Misses 2592 2592
Partials 240 240
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ggregator/exponential/mapping/exponent/exponent.go | 100.0% <100.0%> (ø) |
|
| ...aggregator/exponential/mapping/internal/float64.go | 100.0% <100.0%> (ø) |
|
| ...regator/exponential/mapping/logarithm/logarithm.go | 100.0% <100.0%> (ø) |
Reviewers, there was a recent change in the specification. This applies the corresponding change to the public exponential histogram mapping functions. PTAL.
(Will be a few days before this is updated.)
~LowerBoundary() needs to be exact to match the the mapping function, will resolve.~ EDIT: resolved.