opentelemetry-go icon indicating copy to clipboard operation
opentelemetry-go copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Add NewExportPipeline and InstallNewPipeline functions to OTLP exporter

Open MrAlias opened this issue 4 years ago • 2 comments

Similar to the other exporters:

  • https://github.com/open-telemetry/opentelemetry-go/blob/3d6e8b5078443c822c3800e89bdb84289d82b084/exporters/metric/prometheus/prometheus.go#L90
  • https://github.com/open-telemetry/opentelemetry-go/blob/fd3c82bec5fc8012da1fdd0402149b38bd8ec59d/exporters/stdout/exporter.go#L53
  • https://github.com/open-telemetry/opentelemetry-go/blob/fd3c82bec5fc8012da1fdd0402149b38bd8ec59d/exporters/trace/jaeger/jaeger.go#L154
  • https://github.com/open-telemetry/opentelemetry-go/blob/fd3c82bec5fc8012da1fdd0402149b38bd8ec59d/exporters/trace/zipkin/zipkin.go#L114

add the NewExportPipeline and InstallNewPipeline convince functions.

MrAlias avatar Nov 18 '20 22:11 MrAlias

Hello, i would to help with this issue, looks like https://github.com/open-telemetry/opentelemetry-collector/pull/2159 can be taken as reasonable defaults.

binjip978 avatar Nov 21 '20 17:11 binjip978

@binjip978 sorry about the late response, thanks for picking this issue up. I think there might be some differences between what the other exporters do and what that example does. We should try to remain consistent with what the other examples do.

MrAlias avatar Dec 01 '20 22:12 MrAlias

:wave: looking through the linked code and wanting to understand the intention of this change since all the examples are slightly different. @MrAlias could you possibly summarize the behavior of these methods for oltp?

eggyhead avatar Oct 07 '22 03:10 eggyhead

This issue is outdated at this point. Closing.

MrAlias avatar Oct 12 '22 15:10 MrAlias