opentelemetry-go-instrumentation icon indicating copy to clipboard operation
opentelemetry-go-instrumentation copied to clipboard

Check that license verification is actually doing the expected

Open rockdaboot opened this issue 1 year ago • 2 comments

Description

The licenses under LICENSES/ seem to be incomplete.

References https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/864#issue-2328073612 https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/864#issuecomment-2142777501

Expected

  • Licenses of all non-Apache2.0 dependencies (direct and indirect) should be stored under LICENSES/.
  • The CI should fail if this is not the case
  • The CI should fail if any stored license file deviates from the upstream license

Required actions

  • Investigate if make verify-licenses works as expected
  • If it does, investigate why the CI doesn't fail
  • If it does not, fix it

rockdaboot avatar Jun 01 '24 12:06 rockdaboot

Hi! Could I pick this up?

mikeblum avatar Feb 11 '25 17:02 mikeblum

@mikeblum, I assigned you.

pellared avatar Feb 11 '25 17:02 pellared