opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard

otelconf: Increase test coverage for Prometheus-related code

Open pellared opened this issue 9 months ago • 4 comments

Any tests that could be added?

i recall running into issues w/ ipv6 support in the collector when i was manually testing this previously.

Originally posted by @codeboten in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6815#pullrequestreview-2628187338

pellared avatar Feb 20 '25 19:02 pellared

could I pick this up? i'm working on prom metrics export on a proj at the moment.

mikeblum avatar Feb 26 '25 16:02 mikeblum

@mikeblum, are you still working on it?

pellared avatar Apr 11 '25 18:04 pellared

Sorry lost track of this one. Not working on it - can i give it back?

mikeblum avatar Apr 15 '25 15:04 mikeblum

Do you still need this task done? I can give it a try

padiazg avatar May 29 '25 13:05 padiazg

I does not seem that @padiazg was working on this issue for almost 2 months.

pellared avatar Jul 21 '25 09:07 pellared

@pellared sorry for the radio silence. I saw https://opentelemetry.io/blog/2024/prom-and-otel/ and it reminded me of this issue. I've got some bandwidth dig into this now. Apart from ipv6 wrt to the above blog post are there other tests we want to add around utf-8 support from Prometheus v3?

mikeblum avatar Sep 04 '25 00:09 mikeblum

other tests we want to add around utf-8 support from Prometheus v3

This can be done but I think it makes sense later when https://github.com/open-telemetry/opentelemetry-configuration/issues/261 is resolved and supported.

pellared avatar Sep 04 '25 09:09 pellared