opentelemetry-go-contrib
opentelemetry-go-contrib copied to clipboard
Add route tag to metrics as well as traces when using otelhttp.WithRouteTag.
Resolves https://github.com/open-telemetry/opentelemetry-go-contrib/issues/611.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: charleskorn / name: Charles Korn (4e27aed5a192320639bc682f95551ba3e7aa611e, 9d4cbe21a6610cacf5ad92e91cafa3cdb7f18c36, 6882ec97d3ada5f5e81b77784d76755df80587e5, fc1ec77be3b995364c1cabd73d9dd447457d2322)
- :white_check_mark: login: pellared / name: Robert Pająk (863b0b8cf7ff361a9162e9ab8be2434d7110d6a9, 4c7f4eb2a0cb778162699b4f6f091528d6718ce8, 8987d759bd07e0e91106076d44fe79f40962aef2, a796aaeef4b281b972d6f37330cba53fca1b1924, be400d8f0d035adb05aa6629733d7c48bfc42384, 7b783c4e68e22b5f7438bea1cbc6ddbfc554bb59, 51482d616ad215eec4ac2f605f48332e1f1d7191, d6ae09e3a7f52ef9b519bb0df3badfd34edab2e2)
Codecov Report
Merging #615 (d6ae09e) into main (bf2ae27) will increase coverage by
0.0%
. The diff coverage is100.0%
.
Additional details and impacted files
@@ Coverage Diff @@
## main #615 +/- ##
=====================================
Coverage 79.3% 79.4%
=====================================
Files 165 165
Lines 10318 10324 +6
=====================================
+ Hits 8183 8198 +15
+ Misses 2000 1992 -8
+ Partials 135 134 -1
Files Changed | Coverage Δ | |
---|---|---|
instrumentation/net/http/otelhttp/handler.go | 86.9% <100.0%> (+3.8%) |
:arrow_up: |
Would it be possible to get a review on this? I'd love to see this functionality implemented.
I'm also needing something like this.
Any concerns about the change? Really want to have this feature. @charleskorn
@charleskorn Can you update the PR? Sorry for the delay.
@charleskorn Can you update the PR? Sorry for the delay.
No worries, done!
@charleskorn Thanks for your contribution 🎉
I am planning to merge this PR. There are only some problems with EasyCLA integration which is blocking this PR. This problem affects other PRs as well.