opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard

Add route tag to metrics as well as traces when using otelhttp.WithRouteTag.

Open charleskorn opened this issue 3 years ago • 4 comments

Resolves https://github.com/open-telemetry/opentelemetry-go-contrib/issues/611.

charleskorn avatar Mar 14 '21 00:03 charleskorn

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: charleskorn / name: Charles Korn (4e27aed5a192320639bc682f95551ba3e7aa611e, 9d4cbe21a6610cacf5ad92e91cafa3cdb7f18c36, 6882ec97d3ada5f5e81b77784d76755df80587e5, fc1ec77be3b995364c1cabd73d9dd447457d2322)
  • :white_check_mark: login: pellared / name: Robert Pająk (863b0b8cf7ff361a9162e9ab8be2434d7110d6a9, 4c7f4eb2a0cb778162699b4f6f091528d6718ce8, 8987d759bd07e0e91106076d44fe79f40962aef2, a796aaeef4b281b972d6f37330cba53fca1b1924, be400d8f0d035adb05aa6629733d7c48bfc42384, 7b783c4e68e22b5f7438bea1cbc6ddbfc554bb59, 51482d616ad215eec4ac2f605f48332e1f1d7191, d6ae09e3a7f52ef9b519bb0df3badfd34edab2e2)

Codecov Report

Merging #615 (d6ae09e) into main (bf2ae27) will increase coverage by 0.0%. The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #615   +/-   ##
=====================================
  Coverage   79.3%   79.4%           
=====================================
  Files        165     165           
  Lines      10318   10324    +6     
=====================================
+ Hits        8183    8198   +15     
+ Misses      2000    1992    -8     
+ Partials     135     134    -1     
Files Changed Coverage Δ
instrumentation/net/http/otelhttp/handler.go 86.9% <100.0%> (+3.8%) :arrow_up:

... and 1 file with indirect coverage changes

codecov[bot] avatar Mar 14 '21 00:03 codecov[bot]

Would it be possible to get a review on this? I'd love to see this functionality implemented.

charleskorn avatar Jul 17 '21 00:07 charleskorn

I'm also needing something like this.

RangelReale avatar Sep 09 '22 16:09 RangelReale

Any concerns about the change? Really want to have this feature. @charleskorn

changliu-wk avatar May 25 '23 14:05 changliu-wk

@charleskorn Can you update the PR? Sorry for the delay.

pellared avatar May 26 '23 06:05 pellared

@charleskorn Can you update the PR? Sorry for the delay.

No worries, done!

charleskorn avatar May 28 '23 00:05 charleskorn

@charleskorn Thanks for your contribution 🎉

pellared avatar Jul 31 '23 09:07 pellared

I am planning to merge this PR. There are only some problems with EasyCLA integration which is blocking this PR. This problem affects other PRs as well.

pellared avatar Jul 31 '23 11:07 pellared