opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard

For golang `go.opentelemetry.io/contrib/config` is not an ideal name

Open bogdandrutu opened this issue 1 year ago • 4 comments

config is very generic name and will potentially conflict with lots of other packages. I would recommend using otelconfig for the package if possible.

bogdandrutu avatar May 09 '24 19:05 bogdandrutu

@codeboten should this be transferred to https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/config?

jack-berg avatar May 16 '24 19:05 jack-berg

I don't have permissions to transfer this over to open-telemetry/opentelemetry-go-contrib, maybe a @open-telemetry/go-approvers member can move the issue

codeboten avatar May 16 '24 20:05 codeboten

Is this issue has any problem prevents moving forward with it ?

is it ready to be assigned ?

Ali-Alnosairi avatar Sep 12 '24 18:09 Ali-Alnosairi

I think otelconf should be also be considered.

MrAlias avatar Sep 12 '24 19:09 MrAlias

Could I pick this up? otelconf makes sense to me.

mikeblum avatar Feb 13 '25 18:02 mikeblum

is this in scope for this refactor?

config: Top-level functions #6602

mikeblum avatar Feb 13 '25 18:02 mikeblum

is this in scope for this refactor?

config: Top-level functions #6602

No. These are separate issues.

pellared avatar Feb 13 '25 20:02 pellared

Since this is a published module, we need to ensure we have a deprecated release of the old name, so folks using it now get a warning letting them know they need to change their import paths to keep getting upgrades.

dmathieu avatar Feb 14 '25 08:02 dmathieu

should I open a PR that deletes the config module or is that premature? was figuring it would hold and get merged after the next release?

mikeblum avatar Feb 26 '25 16:02 mikeblum

You can open it and keep it as draft until the release happens.

dmathieu avatar Feb 26 '25 16:02 dmathieu

With both:

  • otelconf: https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6796
  • config: https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6894

merged to main I think we can close out this issue as done or do we need to wait for the next release?

mikeblum avatar Mar 11 '25 16:03 mikeblum