opentelemetry-go-contrib
opentelemetry-go-contrib copied to clipboard
For golang `go.opentelemetry.io/contrib/config` is not an ideal name
config is very generic name and will potentially conflict with lots of other packages. I would recommend using otelconfig for the package if possible.
@codeboten should this be transferred to https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/config?
I don't have permissions to transfer this over to open-telemetry/opentelemetry-go-contrib, maybe a @open-telemetry/go-approvers member can move the issue
Is this issue has any problem prevents moving forward with it ?
is it ready to be assigned ?
I think otelconf should be also be considered.
Could I pick this up? otelconf makes sense to me.
is this in scope for this refactor?
No. These are separate issues.
Since this is a published module, we need to ensure we have a deprecated release of the old name, so folks using it now get a warning letting them know they need to change their import paths to keep getting upgrades.
should I open a PR that deletes the config module or is that premature? was figuring it would hold and get merged after the next release?
You can open it and keep it as draft until the release happens.
With both:
otelconf: https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6796
config: https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6894
merged to main I think we can close out this issue as done or do we need to wait for the next release?