opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard

Deprecate and remove go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho

Open MrAlias opened this issue 1 year ago • 6 comments

This module has been identified to not have an owner. Based on the project's ownership policy, this module will be deprecated and then removed.

How to keep this module

For this module to continue in this repository, it needs a sponsor.

If you would like to sponsor this module and become an owner, please comment in this issue about your desire. As an owner you will assume the following responsibilities:

  • You will need to be a member of the OpenTelemetry organization and maintain that membership.
    • If you are not an existing member, we can add you to the community. This is not a disqualification, but something you will need in the process of becoming a sponsor.
  • You will be responsible for keeping up with the instrumented library. Any "upstream" changes that impact this module need to be proactively handle by you.
  • You will be expected to review any Pull Requests or Issues created that relate to this module.
  • You will be responsible for the stability and versioning compliance of the module.

You will need to have a good working knowledge of the code this module is instrumenting and, ideally, familiarity with the existing module code.

How this module will be removed

This module is in the process of being deprecated. After that deprecation notice has been published, we will wait 3 months or 2 two releases (whichever is the longer time period). After that time period, this module will be removed from this repository and no more versions of the module will be published.

Resurrection

If a sponsor is found after the module has been deprecated or removed, these operations can be reversed (i.e. coded added back, deprecation notice removed).

MrAlias avatar May 09 '24 19:05 MrAlias

Hi, I want to become the maintainer of this. We use otel and echo a lot internally. Next steps?

debuggerpk avatar Jul 22 '24 00:07 debuggerpk

We recommend you to join the next SIG meeting so you can introduce yourself. You can find the date/hour and zoom link for that meeting in the shared calendar: https://github.com/open-telemetry/community/?tab=readme-ov-file#calendar

See also https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CONTRIBUTING.md#code-owners

dmathieu avatar Jul 22 '24 07:07 dmathieu

This is now on the verge of removal. If @debuggerpk has not stepped in already, is there a chance an existing member can pick up maintenance of this library? I see past activity by @dmathieu, @MrAlias @pellared.

Echo is one of the top HTTP frameworks for Go, it would be a shame to lose official support. I imagine many people would be able to contribute but cannot dedicate time to an OpenTelemetry organization membership.

ricardobeat avatar Aug 13 '24 13:08 ricardobeat

I plan to attend tommorow's meeting.

debuggerpk avatar Aug 14 '24 09:08 debuggerpk

Hi can I get some update on this ? @debuggerpk will you be the maintainer of this module in the future ? thanks

chr1shung avatar Aug 27 '24 02:08 chr1shung

unfortunately no. despite my best efforts, i cannot seem to find time.

debuggerpk avatar Aug 27 '24 20:08 debuggerpk

Hi guys, I'm happy to become the code owner for this project, currently using this for work. However due to timezone (4 am) restrictions I won't be able to attend the go SIG (might change in the future), hope that's fine since I think I qualify all the requirements.

And a follow up question what does versioning compliance of the module. entail?

scorpionknifes avatar Sep 20 '24 03:09 scorpionknifes

Hi @scorpionknifes. Were you able to become the code owner?

myorn avatar Oct 02 '24 08:10 myorn

@scorpionknifes, feel free to create a PR that would make you a code owner. I guess both me and @dmathieu can support you as we have seen you active and appreciate your contributions.

versioning compliance of the module

IMO it means to follow https://github.com/open-telemetry/opentelemetry-go/blob/main/VERSIONING.md (and https://go.dev/doc/modules/version-numbers). Probably we should clarify it in the docs.

pellared avatar Oct 02 '24 09:10 pellared