opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Remove instrgen

Open pellared opened this issue 1 year ago • 2 comments

It looks like instrgen is no longer maintained. https://github.com/open-telemetry/opentelemetry-go-contrib/pull/3682 is the last PR which was submitted more than year a ago.

I propose removing instrgen unless there is someone willing to maintain it.

I believe it is safe to remove the module so since it was never released, and we have the code in the Git history if we wish to resurrect the component in the future. This change will make CI faster and less flaky. We would also get rid of this PR: https://github.com/open-telemetry/opentelemetry-go-contrib/pull/5494.

CC @pdelewski @MrAlias (as codeowners)

pellared avatar May 08 '24 07:05 pellared

@pellared @MrAlias There are few opened PRs that nobody reviewed up to date like https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4636, https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4058 and so on. To continue work on that we need at least one other person and support from maintainers of this repo.

pdelewski avatar May 08 '24 13:05 pdelewski

There is an ongoing discussion to donate the golang compile time instrumentation from Alibaba Cloud. We found that the approach shares the similar idea with what InstrGen does and we are working on a solution to combine the two approaches. https://github.com/open-telemetry/community/issues/1961

ralf0131 avatar May 20 '24 02:05 ralf0131

Resolved by https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6671

MrAlias avatar Jan 31 '25 21:01 MrAlias