opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

[WIP]hostmetrics: add additional metrics for host

Open TelmoMtzLarrinaga opened this issue 1 year ago • 5 comments

This PR adds the following additional metrics for the host instrumentation: - system.cpu.utilization - system.cpu.logical.count - system.cpu.physical.count

Closes #4443

TelmoMtzLarrinaga avatar Oct 24 '23 12:10 TelmoMtzLarrinaga

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: TelmoMtzLarrinaga (3909f44d130dd53388625542f145524b7780be97)
  • :white_check_mark: login: pellared / name: Robert Pająk (28a2ee1ce5ec6d36d381a964c93a611bcd1e99a6)

linux-foundation-easycla[bot] avatar Oct 24 '23 12:10 linux-foundation-easycla[bot]

Please also update CHANGELOG.md and doc.go in the package.

pellared avatar Oct 24 '23 14:10 pellared

I have seen all the feedback. Thanks for taking the time; I greatly appreciate it, really.

Are you able to add tests?

I'll look into it. I will try to go through it carefully so it doesn't requiere multiple iterations if i end up adding them.

TelmoMtzLarrinaga avatar Oct 25 '23 11:10 TelmoMtzLarrinaga

Hi there, are there any update on this Pull Request?

herrBez avatar Nov 23 '23 13:11 herrBez

Hi @herrBez! I still have to look into adding test for the instrumentation. Right now i kind of a bit caught up with other work, so unfortunately, not updates from my part. Sorry for the inconvenience, really.

TelmoMtzLarrinaga avatar Nov 23 '23 14:11 TelmoMtzLarrinaga