opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard

Proposal: Add S3 attributes `AttributeSetter` to `DefaultAttributeSetter`

Open gdavison opened this issue 2 years ago • 1 comments

Problem Statement

The OTel Semantic Conventions extend the AWS SDK Semantic Conventions for two services: DynamoDB and S3.

The otelaws package defines AttributeSetters for DynamoDB and SQS (using generic Messaging System semantic conventions, maybe v1.17.0).

There is no equivalent AttributeSetter for S3.

Proposed Solution

Add an AttributeSetter for S3 to otelaws.

Would a PR be accepted?

Alternatives

Users of otelaws could define their own AttributeSetter for S3 and pass it when configuring the otel middleware.

Prior Art

There are existing AttributeSetters for DynamoDB and SQS.

gdavison avatar Sep 20 '23 18:09 gdavison

That seems like a good idea.

dmathieu avatar Sep 21 '23 07:09 dmathieu