change the Filter parameter from *http.Request to *gin.Context

[soyacen]

change the Filter parameter from *http.Request to *gin.Context.

gin.Context has FullPath() method, which returns a matched route full path.

// router.GET("/user/:id", func(c *gin.Context) { // c.FullPath() == "/user/:id" // true // })

[rehanpfmr]

@soyacen Can you add the link to the .go file?

[dmathieu]

I suppose this is the option being mentioned: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/github.com/gin-gonic/gin/otelgin/option.go#L78

Which is used here: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/github.com/gin-gonic/gin/otelgin/gintrace.go#L57

@rehanpfmr this should be a straightforward change. If you want to take it, feel free to do so.

[rehanpfmr]

@soyacen @dmathieu Please assign this to me.

[riking]

FullPath is already being used as the span name, so that half of this ticket can be ignored.