opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard
verified publisher icon open-telemetry

Add integration testing to the runtime instrumenation

Open MrAlias opened this issue 3 years ago • 4 comments

Integration testing for the runtime instrumentation was removed in https://github.com/open-telemetry/opentelemetry-go-contrib/pull/2756

When https://github.com/open-telemetry/opentelemetry-go/issues/3031 is resolved, a new runtime/test package need to be created and integration testing for the instrumentation added to it.

MrAlias avatar Sep 16 '22 17:09 MrAlias

Note that I don't think we should restore these tests, instead write new ones as described in https://github.com/open-telemetry/opentelemetry-go-contrib/issues/2624 and https://github.com/open-telemetry/opentelemetry-go-contrib/issues/2625. I've drafted such tests in https://github.com/lightstep/otel-launcher-go/tree/main/lightstep/instrumentation/runtime.

jmacd avatar Sep 19 '22 16:09 jmacd

Blocked by https://github.com/open-telemetry/opentelemetry-go/issues/3407

MrAlias avatar Oct 28 '22 16:10 MrAlias

Unblocked. Use a manual-reader to collect expected metrics and the metricdatatest package to compare expected values (or just compare directly).

MrAlias avatar Oct 31 '22 15:10 MrAlias

Blocked by:

  • https://github.com/open-telemetry/opentelemetry-go-contrib/issues/2648
  • https://github.com/open-telemetry/opentelemetry-go-contrib/issues/2625
  • https://github.com/open-telemetry/opentelemetry-go-contrib/issues/2624
  • https://github.com/open-telemetry/opentelemetry-go-contrib/issues/1341
  • https://github.com/open-telemetry/opentelemetry-go-contrib/issues/368
  • https://github.com/open-telemetry/opentelemetry-go-contrib/issues/316

MrAlias avatar Nov 03 '22 18:11 MrAlias