opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

process.runtime.go.cgo.calls metric should be Counter

Open vmihailenco opened this issue 2 years ago • 2 comments

runtime.NumCgoCall() returns a monotonic number which never goes down so I guess it should be a Counter.

https://github.com/open-telemetry/opentelemetry-go-contrib/commit/a5875205b0664b93cb05667e49c034b94576a4c7 changed process.runtime.go.cgo.calls from Counter to UpDownCounter without providing a reason. Perhaps it was a typo?

vmihailenco avatar Aug 13 '22 10:08 vmihailenco

Agreed. I want to retire the library producing this metric, however, see https://github.com/open-telemetry/opentelemetry-go-contrib/pull/2643 and plan on discussing this topic in the 9/8 Go SIG call.

jmacd avatar Sep 07 '22 14:09 jmacd

i have a question concerning this:

Has the library been retired @jmacd ? If not, I would like to work on this issue @MrAlias

AkhigbeEromo avatar Mar 19 '24 13:03 AkhigbeEromo