opentelemetry-go-contrib
opentelemetry-go-contrib copied to clipboard
[net/http] enhance otelhttp example to support metric
Signed-off-by: Ziqi Zhao [email protected]
The current otelhttp example only contains the logic of traces, I added the support of metric.
The metrics SDK is currently under heavy revamping to be moved out of beta (see the new_sdk branch). I think this kind of change should wait for that work to be finished.
@dmathieu @MrAlias Already update to latest metric sdk, please help review this again, thanks!
All comments are resolved @MrAlias
Codecov Report
Merging #2610 (73f5f3c) into main (e97d789) will increase coverage by
0.0%
. The diff coverage is89.4%
.
Additional details and impacted files
@@ Coverage Diff @@
## main #2610 +/- ##
=====================================
Coverage 69.6% 69.6%
=====================================
Files 147 147
Lines 6785 6795 +10
=====================================
+ Hits 4725 4735 +10
Misses 1944 1944
Partials 116 116
Impacted Files | Coverage Δ | |
---|---|---|
samplers/jaegerremote/sampler_remote.go | 87.4% <50.0%> (ø) |
|
instrumentation/net/http/otelhttp/handler.go | 81.9% <100.0%> (+0.5%) |
:arrow_up: |
samplers/jaegerremote/sampler_remote_options.go | 100.0% <100.0%> (ø) |
the failed check seems to be flaky, could you trigger this again? @dmathieu @MrAlias