opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard

[net/http] enhance otelhttp example to support metric

Open fatsheep9146 opened this issue 2 years ago • 1 comments

Signed-off-by: Ziqi Zhao [email protected]

The current otelhttp example only contains the logic of traces, I added the support of metric.

fatsheep9146 avatar Jul 28 '22 05:07 fatsheep9146

The metrics SDK is currently under heavy revamping to be moved out of beta (see the new_sdk branch). I think this kind of change should wait for that work to be finished.

dmathieu avatar Jul 28 '22 07:07 dmathieu

@dmathieu @MrAlias Already update to latest metric sdk, please help review this again, thanks!

fatsheep9146 avatar Nov 04 '22 05:11 fatsheep9146

All comments are resolved @MrAlias

fatsheep9146 avatar Nov 06 '22 01:11 fatsheep9146

Codecov Report

Merging #2610 (73f5f3c) into main (e97d789) will increase coverage by 0.0%. The diff coverage is 89.4%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2610   +/-   ##
=====================================
  Coverage   69.6%   69.6%           
=====================================
  Files        147     147           
  Lines       6785    6795   +10     
=====================================
+ Hits        4725    4735   +10     
  Misses      1944    1944           
  Partials     116     116           
Impacted Files Coverage Δ
samplers/jaegerremote/sampler_remote.go 87.4% <50.0%> (ø)
instrumentation/net/http/otelhttp/handler.go 81.9% <100.0%> (+0.5%) :arrow_up:
samplers/jaegerremote/sampler_remote_options.go 100.0% <100.0%> (ø)

codecov[bot] avatar Nov 08 '22 07:11 codecov[bot]

the failed check seems to be flaky, could you trigger this again? @dmathieu @MrAlias

fatsheep9146 avatar Nov 08 '22 08:11 fatsheep9146