opentelemetry-go-contrib
opentelemetry-go-contrib copied to clipboard
Add trace propagation for otelkit endpoints (#2166)
Trace propagation for otelkit currently supports:
- gRPC via GrpcPropagationMiddleware
- HTTP via HttpPropagationMiddleware
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: drewtoto (25682b82a397b75b5b7605759406024f7cf42033)
Is there any action I have to do here? Github is telling me this branch has conflicts with go.mod
and test/go.mod
but I'm not seeing any conflicts - am I just missing something here?
Is there any action I have to do here? Github is telling me this branch has conflicts with
go.mod
andtest/go.mod
but I'm not seeing any conflicts - am I just missing something here?
You need to merge the main
upstream branch into this branch. Successfully doing so will require you to resolve the change conflicts between the two branches.
Codecov Report
Merging #2167 (bf9f626) into main (b8df9ac) will decrease coverage by
0.0%
. The diff coverage is70.3%
.
:exclamation: Current head bf9f626 differs from pull request most recent head 607b1e0. Consider uploading reports for the commit 607b1e0 to get more accurate results
@@ Coverage Diff @@
## main #2167 +/- ##
=======================================
- Coverage 73.6% 73.6% -0.1%
=======================================
Files 141 142 +1
Lines 6382 6409 +27
=======================================
+ Hits 4699 4718 +19
- Misses 1541 1549 +8
Partials 142 142
Impacted Files | Coverage Δ | |
---|---|---|
...ation/github.com/go-kit/kit/otelkit/propagation.go | 70.3% <70.3%> (ø) |
File permission and lint issues need to be addressed before this is ready to be comprehensively reviewed.
Thank you for this comment - I am in the process of fixing file permissions (my IDE is changing these and it's really frustrating) and adding the extra tests for code coverage.