opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard

[Performance issues] use grpc metadata FromOutgoingContext function

Open AtlanCI opened this issue 3 years ago • 1 comments

Background

grpc version 1.39 and 1.37 Package Link: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go StreamClientInterceptor and UnaryClientInterceptor

Proposed Solution

The fromoutgoingcontext implementation in grpc versions 1.39 and 1.37 is different. In 1.37, it parses CTX using the join function. Whether the appendtooutgoingcontext function should be used in opentelemetry.

AtlanCI avatar Aug 27 '21 09:08 AtlanCI

260b6c46df5f5bfe06f595d82c47719 Replace with this function fromoutgoingcontext

AtlanCI avatar Aug 27 '21 09:08 AtlanCI