opentelemetry-erlang icon indicating copy to clipboard operation
opentelemetry-erlang copied to clipboard

breaking changes in recent version

Open epinault opened this issue 4 months ago • 6 comments

Hello

we are seeing this error after upgrading

span exporter threw exception: exporter=:opentelemetry_exporter exception error: bad generator {tracestate,[]}
  in function  otel_otlp_traces:'-to_tracestate_string/1-lc$^0/1-0-'/1 (/code/deps/opentelemetry_exporter/src/otel_otlp_traces.erl, line 134)
  in call from otel_otlp_traces:to_tracestate_string/1 (/code/deps/opentelemetry_exporter/src/otel_otlp_traces.erl, line 134)
  in call from otel_otlp_traces:to_proto/1 (/code/deps/opentelemetry_exporter/src/otel_otlp_traces.erl, line 88)
  in call from otel_otlp_traces:'-to_proto_by_instrumentation_scope/2-fun-0-'/2 (/code/deps/opentelemetry_exporter/src/otel_otlp_traces.erl, line 58)
  in call from lists:foldl/3 (lists.erl, line 1594)
  in call from otel_otlp_traces:to_proto_by_instrumentation_scope/2 (/code/deps/opentelemetry_exporter/src/otel_otlp_traces.erl, line 57)
  in call from otel_otlp_traces:to_proto/2 (/code/deps/opentelemetry_exporter/src/otel_otlp_traces.erl, line 34)
  in call from opentelemetry_exporter:export/4 (/code/deps/opentelemetry_exporter/src/opentelemetry_exporter.erl, line 259)

we had prior to the breakage:

 "opentelemetry": {:hex, :opentelemetry, "1.3.1", "f0a342a74379e3540a634e7047967733da4bc8b873ec9026e224b2bd7369b1fc", [:rebar3], [{:opentelemetry_api, "~> 1.2.2", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}, {:opentelemetry_semantic_conventions, "~> 0.2", [hex: :opentelemetry_semantic_conventions, repo: "hexpm", optional: false]}], "hexpm", "de476b2ac4faad3e3fe3d6e18b35dec9cb338c3b9910c2ce9317836dacad3483"},
  "opentelemetry_api": {:hex, :opentelemetry_api, "1.2.2", "693f47b0d8c76da2095fe858204cfd6350c27fe85d00e4b763deecc9588cf27a", [:mix, :rebar3], [{:opentelemetry_semantic_conventions, "~> 0.2", [hex: :opentelemetry_semantic_conventions, repo: "hexpm", optional: false]}], "hexpm", "dc77b9a00f137a858e60a852f14007bb66eda1ffbeb6c05d5fe6c9e678b05e9d"},

We had an update to

 "opentelemetry": {:hex, :opentelemetry, "1.4.0", "f928923ed80adb5eb7894bac22e9a198478e6a8f04020ae1d6f289fdcad0b498", [:rebar3], [{:opentelemetry_api, "~> 1.3.0", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}, {:opentelemetry_semantic_conventions, "~> 0.2", [hex: :opentelemetry_semantic_conventions, repo: "hexpm", optional: false]}], "hexpm", "50b32ce127413e5d87b092b4d210a3449ea80cd8224090fe68d73d576a3faa15"},
  "opentelemetry_api": {:hex, :opentelemetry_api, "1.3.0", "03e2177f28dd8d11aaa88e8522c81c2f6a788170fe52f7a65262340961e663f9", [:mix, :rebar3], [{:opentelemetry_semantic_conventions, "~> 0.2", [hex: :opentelemetry_semantic_conventions, repo: "hexpm", optional: false]}], "hexpm", "b9e5ff775fd064fa098dba3c398490b77649a352b40b0b730a6b7dc0bdd68858"},

all of these are minor changes, and not breaking change per the semantic. Yet this introduced a breakage . I see no mark of breaking changes https://github.com/open-telemetry/opentelemetry-erlang/blob/main/CHANGELOG.md

I am not sure what this error mean either but any idea what the issue might be?

epinault avatar Apr 25 '24 16:04 epinault