Only call tls_certificate_check when no explicit ssl_options provided

[danmarcab]

Should fix https://github.com/open-telemetry/opentelemetry-erlang/issues/350

Tries to mimic what is done in:

https://github.com/open-telemetry/opentelemetry-erlang/blob/main/apps/opentelemetry_exporter/src/opentelemetry_exporter.erl#L268-L273

[linux-foundation-easycla[bot]]

• :x: The commit (0a5fbc8ac386024dc4b251a8c80c63ee16987d48) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[linux-foundation-easycla[bot]]

• :x: The commit (0a5fbc8ac386024dc4b251a8c80c63ee16987d48) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[tsloughter]

But it only calls tls_certificate_check if the ssl opts are undefined. So this shouldn't change whether it is called or not?

[codecov[bot]]

Codecov Report

Merging #351 (512f76b) into main (2b8d7b2) will decrease coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   33.55%   33.51%   -0.04%     
==========================================
  Files          56       56              
  Lines        4557     4556       -1     
==========================================
- Hits         1529     1527       -2     
- Misses       3028     3029       +1     

Flag	Coverage Δ
api	68.90% <ø> (ø)
elixir	16.47% <ø> (ø)
erlang	33.45% <100.00%> (-0.04%)	:arrow_down:
exporter	21.39% <100.00%> (-0.08%)	:arrow_down:
sdk	77.13% <ø> (ø)
zipkin	2.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ntelemetry_exporter/src/opentelemetry_exporter.erl	75.00% <100.00%> (-0.78%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b8d7b2...512f76b. Read the comment docs.

[tsloughter]

Hey, really sorry I dropped the ball on this for so long. I have actually opened a separate PR #434 with an alternative solution.

Pls reopen this if you don't like mine :)