opentelemetry-erlang-contrib icon indicating copy to clipboard operation
opentelemetry-erlang-contrib copied to clipboard

Extra metadata to add to telemetry events for Redix

Open prabhjotlalli opened this issue 1 year ago • 3 comments

These end up in :extra_metadata metadata key to pass along.

prabhjotlalli avatar Jan 31 '24 03:01 prabhjotlalli

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: prabhjotlalli / name: Prabhjot Lalli (e0b735ec317525325db82919e2ce822fc142084c, a25b15a9015e85b422fcdcc345f6f9309c208680, 2e2fc805ee2d7032ec349ca9a25760dd47d6c778, 445ea296c7753909724869afe1dfcf80d563fff2)

Would folks always want all the metadata as attributes or just particular keys? I imagine folks would want more control.

bryannaegele avatar Feb 14 '24 05:02 bryannaegele

@bryannaegele I went with passing along everything since it's what is expected by the library https://hexdocs.pm/redix/Redix.Telemetry.html

I'm open to having a set list of keys if you can point me to what we would want to limit it to.

prabhjotlalli avatar Feb 14 '24 16:02 prabhjotlalli