opentelemetry-erlang-contrib icon indicating copy to clipboard operation
opentelemetry-erlang-contrib copied to clipboard

Add bandit telemetry support for opentelemetry-phoenix

Open solar05 opened this issue 1 year ago • 6 comments

New Project

Telemetry handler that creates Opentelemetry spans from Bandit events. Project link.

Checklist

Acknowledgements

  • [x] I certify that I am authorized to assign ownership of this code to the OpenTelemetry project.
  • [x] I acknowledge that ownership of the Hex package must be given/transferred to the OpenTelemetry Hex Org

Project Type

  • [x] Instrumentation
  • [ ] Exporter
  • [ ] Propagator
  • [ ] Metapackage
  • [ ] Example
  • [ ] Util

Prior Art

  • [ ] Is this an existing project? Includes private libraries being open sourced.
    • [x] Yes
    • [ ] No
  • [ ] Are there any other packages on Hex providing similar functionality?

Existing Project

  • [x] Moving from an existing public repository? Provide a link in the description.
  • [x] All authors who have contributed code contained in this PR have signed the CNCF CLA

All Projects

  • [x] Label created (maintainers)
  • [x] labeler.yml updated
  • [x] CI
    • [x] Elixir or Erlang language file is updated
    • [x] Test strategy should use the matrix strategy with all supported language/OTP combinations
    • [x] The job is scoped to only run for relevant code changes
  • [x] Codeowners adds scoped ownership for project maintainers
  • [x] License file (Apache2 - copyright to OpenTelemetry Authors)
  • [x] All code complies with the Otel Specification and Otel Semantic Conventions - Trace Metrics

solar05 avatar Dec 15 '23 12:12 solar05

This is awesome. Will take a look after the new year.

Could you move the core project over here and transfer ownership? We had this in the roadmap and it looks like your implementation still needs a fair amount of work.

bryannaegele avatar Dec 19 '23 20:12 bryannaegele

@solar05 ping.

Simplebet will be able to invest time building the library out if we can get the transfer completed. We'd prefer to not have a second version in the ecosystem if at all possible.

bryannaegele avatar Jan 17 '24 16:01 bryannaegele

@bryannaegele oh, sorry, got busy weeks! Moved core project. What kind of ownership is meant? Hexpm?

solar05 avatar Feb 03 '24 11:02 solar05

Awesome! Here's a PR template https://github.com/open-telemetry/opentelemetry-erlang-contrib/blob/main/.github/PULL_REQUEST_TEMPLATE/new_project_template.md for transferring. And yeah, the package transfer would be ownership to the org.

bryannaegele avatar Feb 05 '24 04:02 bryannaegele

@bryannaegele So, I updated PR description according to the new project template, also transferred package ownership to opentelemetry.

solar05 avatar Feb 06 '24 13:02 solar05

Thank you! I'll try to get this merged this week.

bryannaegele avatar Feb 12 '24 22:02 bryannaegele

@bryannaegele Is there a release planned for opentelemetry_phoenix to include the :bandit adapter to OpentelemetryPhoenix.setup/1?

ianko avatar Feb 29 '24 17:02 ianko

@ianko we need a change in bandit and some refactoring to sign off on making it an option as it currently degrades the default behavior of the phoenix instrumenter. Once that all happens, we can expose it as an option.

bryannaegele avatar Mar 13 '24 16:03 bryannaegele

@ianko we need a change in bandit and some refactoring to sign off on making it an option as it currently degrades the default behavior of the phoenix instrumenter. Once that all happens, we can expose it as an option.

Is there a discussion regarding this that can be followed somewhere?

barkerja avatar Apr 01 '24 14:04 barkerja

@ianko we need a change in bandit and some refactoring to sign off on making it an option as it currently degrades the default behavior of the phoenix instrumenter. Once that all happens, we can expose it as an option.

Seconding @barkerja - is there somewhere we can follow this? Would be extremely timely and useful for us.

akasprzok avatar Apr 10 '24 19:04 akasprzok