opentelemetry-erlang-contrib icon indicating copy to clipboard operation
opentelemetry-erlang-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Improve Oban plugin handler and fix error handling

Open andrewhr opened this issue 2 years ago • 2 comments

The main purpose of this patch is to introduce plugin aware attributes - mostly counts of processed jobs.

Plugins cover all the offerings of Oban 2.15 and Oban Pro 1.0, the current versions at time of writing.

While testing this in a real app, I've noticed issues with exception handlers for plugin. Decided to slip in this patch changes to both job and plugin event handlers to rely on standard :telemetry.span/3 attributes instead of :error key (which seems like an artifact of earlier versions).

andrewhr avatar Aug 21 '23 16:08 andrewhr

I don't know anything about Oban plugins. @indrekj can you comment on this? @bryannaegele any thoughts?

tsloughter avatar Aug 31 '23 09:08 tsloughter

@andrewhr any comments on @indrekj's notes?

tsloughter avatar Sep 15 '23 22:09 tsloughter